Writing RTL that “works in sim” is only half the job. In companies, another engineer (or a tool) will ask: is this safe to synthesize, maintain, and tape out? This lesson teaches the review lens you will use for every later module — including your I2C capstone.
A restaurant kitchen is not only judged by taste. Health inspectors check cleanliness, process, and labels. RTL review is the health inspection for chips.
Use this on every lab — including the tiny passthrough from Lesson 0.2. Module 9 will deepen each row.
| Category | Reviewer asks… | Quick self-test |
|---|---|---|
| Readable | Can a teammate explain this in 10 min? | Module header + sensible signal names |
| Synthesizable | Will synthesis infer latches or reject constructs? | No #delay in RTL; complete if/case in combo |
| Reset-clean | Known state after reset? | Every flop has reset path; control FSM has RESET state |
| Clock-clean | One clock per flop domain? | No gated clocks inside RTL without documented reason |
| Lint-clean | Width mismatches, multi-drivers, unused logic? | Run mental pass: port widths match, one driver per net |
| CDC-aware | Cross-clock signals handled? | Single-bit sync or FIFO — never raw multi-bit bus |
| Timing-aware | Long combo paths? | Flag deep arithmetic; pipeline if needed (Module 8) |
| Verified | Tests that would fail if broken? | At least reset test + one functional scenario |
You will not master every row today. You will start noticing them. That awareness is the difference between tutorial Verilog and job-ready RTL.
Example A — reset
always @(posedge clk) begin q <= d; end
always @(posedge clk or negedge rst_n) begin if (!rst_n) q <= 1'b0; else q <= d; end
Example B — latch
always @(*) begin if (enable) out = in; end
always @(*) begin out = 1'b0; if (enable) out = in; end
Example C — FSM
case (state) IDLE: next = START; START: next = DATA; endcase
case (state) IDLE: next = START; START: next = DATA; default: next = IDLE; endcase
| Topic | Typical comment | Your fix |
|---|---|---|
| Naming | Rename cryptic signals | Role-based names; _n for active-low |
| Resets | Unknown state at power-up | Document reset strategy in header |
| FSMs | Missing diagram / default | localparam states; default to safe IDLE |
| CDC | Raw bus across clocks | FIFO or handshake — Module 9 |
| Lint | Width mismatch | Explicit casts; match widths |
| TB | Happy path only | Reset + stress tests; note in reply |
Template: Comment N: [done/deferred] — fix summary — proof
I2C capstone uses the same sign-off loop.
Incomplete if/case in combo logic. Looks fine until silicon or FPGA maps a latch.
Wrong assignment style → sim/synth mismatch. Module 3 drills this hard.
Passing a multi-bit counter into another clock “because it worked once.”
Only happy-path TB. Reviewers ask: what did you try to break?
Mindset: assume your first draft has at least one of these. Hunting it is normal — not failure.
Red flags that fail reviews (no merge until fixed):
=) in clocked always blocks driving flops#delay or initial blocks inside synthesizable RTL modules